Skip to content

Add support for ip data type in ES Connector#14996

Merged
zhenxiao merged 1 commit intoprestodb:masterfrom
agrawalreetika:ES-14806
Aug 11, 2020
Merged

Add support for ip data type in ES Connector#14996
zhenxiao merged 1 commit intoprestodb:masterfrom
agrawalreetika:ES-14806

Conversation

@agrawalreetika
Copy link
Member

@agrawalreetika agrawalreetika commented Aug 9, 2020

Add support for IP data type in ES Connector. #14806

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 9, 2020

CLA Check
The committers are authorized under a signed CLA.

  • ✅ Reetika (a93953a93c7f953a78500b8216bd5f3b7529d596)

Copy link
Collaborator

@zhenxiao zhenxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @agrawalreetika thanks for the work
are you cherry picking: trinodb/trino@58dffcd

if so, could you please add cherry-pick message and co-authors in the commit message? You could take a look as previous cherry-pick commits format :)

@agrawalreetika
Copy link
Member Author

hi @agrawalreetika thanks for the work
are you cherry picking: prestosql/presto@58dffcd

if so, could you please add cherry-pick message and co-authors in the commit message? You could take a look as previous cherry-pick commits format :)

Thanks for the review, I have added cherry-pick message and co-authors by looking at some previous PRs.

Cherry pick of trinodb/trino@58dffcd

Co-authored-by: eskabetxe <boto@boto.pro>
Copy link
Collaborator

@zhenxiao zhenxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhenxiao zhenxiao merged commit eed2581 into prestodb:master Aug 11, 2020
@caithagoras caithagoras mentioned this pull request Aug 14, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants