Allow procedures to have optional arguments with default values#14988
Merged
wenleix merged 1 commit intoprestodb:masterfrom Aug 11, 2020
Merged
Allow procedures to have optional arguments with default values#14988wenleix merged 1 commit intoprestodb:masterfrom
wenleix merged 1 commit intoprestodb:masterfrom
Conversation
vivek-bharathan
force-pushed
the
procdefaultargs
branch
from
69bcf6a to
0bbdb60
Compare
wenleix
approved these changes
Aug 7, 2020
Contributor
wenleix
left a comment
wenleix
left a comment
There was a problem hiding this comment.
LGTM.
@ClarenceThreepwood Can you add description about motivation and the release notes in the PR before i merge it?
Contributor
Author
|
Thanks @wenleix - it should be ok to merge now |
Contributor
|
Merged #14988. Thanks for the contribution! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick trinodb/trino@7a7404d
This change allows procedures to be defined with optional arguments or default values for arguments