Support more than 1 druid source#14980
Merged
zhenxiao merged 1 commit intoprestodb:masterfrom Aug 13, 2020
Merged
Conversation
weidongduan37
force-pushed
the
support_union_all_druid
branch
from
42390fd to
d497986
Compare
zhenxiao
requested changes
Aug 6, 2020
Collaborator
zhenxiao
left a comment
zhenxiao
left a comment
There was a problem hiding this comment.
nice catch, @weidongduan37
could we add testcase in: TestDruidQueryGenerator?
Previously, only allow 1 druid source. Now will try to push down operations under UnionNode, and union (all) data at presto side.
weidongduan37
force-pushed
the
support_union_all_druid
branch
from
d497986 to
d700fa1
Compare
Contributor
Author
Hi @zhenxiao, it's not easy to add test case in TestDruidQueryGenerator directly because it's only available for 1 druid sql generated case. I try to add a new testDruidPlanOptimizer class to cover more than 1 druid sql generated case. Thanks, |
zhenxiao
approved these changes
Aug 13, 2020
Collaborator
zhenxiao
left a comment
zhenxiao
left a comment
There was a problem hiding this comment.
nice work, @weidongduan37
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow union and union all operation