Convert revocable memory to user memory on hash aggregation finish#14971
Merged
highker merged 1 commit intoprestodb:masterfrom Aug 6, 2020
Merged
Convert revocable memory to user memory on hash aggregation finish#14971highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
sachdevs
force-pushed
the
convert-revocable-to-user
branch
from
5ddd21f to
55f5e8a
Compare
Contributor
Author
|
Renamed commit to be shorter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spillable hash aggregation keeps allocated memory in revocable memory pool instead of converting it during finish. This is a bug. I have also moved some of our tracking logic for when operator is finishing to SpillableHashAggregationBuilder.
Adapted from second commit in trinodb/trino#164.