Use the same RowExpressionCompiler when compiling expressions#14959
Merged
rongrong merged 1 commit intoprestodb:masterfrom Aug 5, 2020
Merged
Use the same RowExpressionCompiler when compiling expressions#14959rongrong merged 1 commit intoprestodb:masterfrom
rongrong merged 1 commit intoprestodb:masterfrom
Conversation
Earlier commit changed CursorProcessorCompiler to use the same RowExpressionCompiler to compile all expressions. We should just use the same RowExpressionCompiler for all expressions within the same class.
rongrong
force-pushed
the
fix-sql-lambda
branch
from
84d6e04 to
dcc93c6
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier commit changed CursorProcessorCompiler to use the same
RowExpressionCompiler to compile all expressions. We should just
use the same RowExpressionCompiler for all expressions within the
same class.
Test plan - See added test