Support skipping control in Verifier#14958
Merged
caithagoras merged 1 commit intoprestodb:masterfrom Aug 5, 2020
Merged
Conversation
Contributor
caithagoras
commented
Aug 5, 2020
caithagoras
commented
caithagoras
changed the title
caithagoras
force-pushed
the
s5
branch
2 times, most recently
from
f990970 to
a63ef21
Compare
caithagoras
changed the title
wenleix
approved these changes
Aug 5, 2020
Contributor
wenleix
left a comment
wenleix
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the work!
presto-verifier/src/main/java/com/facebook/presto/verifier/event/VerifierQueryEvent.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
Outdated
Show resolved
Hide resolved
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.