Connect to Cassandra cluster using SSL#14950
Connect to Cassandra cluster using SSL#14950highker merged 1 commit intoprestodb:masterfrom SandishKumarHN:master
Conversation
|
@SandishKumarHN thank you for your contribution! This is something community has brought up. Can you share your testing approach? |
There was a problem hiding this comment.
@highker I did not understand this comment. PemReader has all static methods.
There was a problem hiding this comment.
import static com.facebook.airlift.security.pem.PemReader.readCertificateChain;
presto-cassandra/pom.xml
Outdated
There was a problem hiding this comment.
break a line between these two. Also, the indentation doesn't look right.
|
@highker thanks for the review, I have made changes based on your review and left a question. looks like the CI failure is not related to the PR. |
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Could you squash your commits into one?
There was a problem hiding this comment.
import static com.facebook.airlift.security.pem.PemReader.readCertificateChain;
|
@highker thanks for the review again, made changes for static import, and squshed into one commit. CI failure is not related to this PR. |
3 participants
Connect to Cassandra cluster with tls security