Shade classes in presto-jdbc uber jar#14944
Merged
wenleix merged 1 commit intoprestodb:masterfrom Aug 3, 2020
Merged
Conversation
prestodb#14585 introduced new dependencies that entered presto-jdbc uber jar. presto-jdbc shades out all dependencies other than the core jdbc classes itself and this PR does the same.
caithagoras
approved these changes
Aug 3, 2020
Contributor
|
Merged #14944, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14585 introduced new dependencies that entered
presto-jdbc uber jar. presto-jdbc shades out all dependencies other than the core jdbc
classes itself and this PR does the same.
Test plan - I will let all unittests succeed before landing this PR