Inline SQL functions at plan time#14931
Merged
rongrong merged 3 commits intoprestodb:masterfrom Aug 13, 2020
Merged
Conversation
prithvip
force-pushed
the
inline-sql-functions
branch
from
06e0085 to
5816ffb
Compare
rongrong
reviewed
Jul 31, 2020
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Looks good overall, please add tests.
presto-main/src/main/java/com/facebook/presto/sql/planner/InlineSqlFunctionsRewriter.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/InlineSqlFunctionsRewriter.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/InlineSqlFunctionsRewriter.java
Outdated
Show resolved
Hide resolved
Contributor
|
Test failures are related, please fix. |
prithvip
force-pushed
the
inline-sql-functions
branch
5 times, most recently
from
3fb7434 to
6725cae
Compare
prithvip
changed the title
prithvip
force-pushed
the
inline-sql-functions
branch
3 times, most recently
from
95d51db to
1f91c73
Compare
rongrong
reviewed
Aug 5, 2020
...ain/src/test/java/com/facebook/presto/sql/planner/iterative/rule/TestInlineSqlFunctions.java
Outdated
Show resolved
Hide resolved
rongrong
approved these changes
Aug 5, 2020
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Looks good! Minor suggestion to add more tests.
prithvip
force-pushed
the
inline-sql-functions
branch
3 times, most recently
from
a870188 to
f661778
Compare
rongrong
reviewed
Aug 11, 2020
presto-main/src/main/java/com/facebook/presto/sql/relational/SqlFunctionUtils.java
Outdated
Show resolved
Hide resolved
prithvip
force-pushed
the
inline-sql-functions
branch
from
f661778 to
53357b1
Compare
prithvip
force-pushed
the
inline-sql-functions
branch
from
53357b1 to
f6075d2
Compare
rongrong
reviewed
Aug 12, 2020
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
You can squash the two commits that fixes the coercion.
presto-main/src/main/java/com/facebook/presto/sql/relational/SqlFunctionUtils.java
Outdated
Show resolved
Hide resolved
prithvip
force-pushed
the
inline-sql-functions
branch
2 times, most recently
from
9f23d48 to
e032df3
Compare
rongrong
reviewed
Aug 12, 2020
Contributor
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Code looks good. The second commit title is too long. We restrict commit title to 72 characters.
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
prithvip
force-pushed
the
inline-sql-functions
branch
from
e032df3 to
1942ea3
Compare
Contributor
|
Let's add a release note about inline sql function. Something like |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.