Add geometry_nearest_points function#14923
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Aug 21, 2020
Merged
Conversation
This function is similar to PostGIS ST_ClosestPoints. Given two geometries, find a pair of points on them that have the minimum distance. If either geometry is empty, return null.
mbasmanova
approved these changes
Aug 21, 2020
Contributor
mbasmanova
left a comment
There was a problem hiding this comment.
@jagill Thank you.
CC: @zhenxiao @adamjshook
| return blockBuilder.build(); | ||
| } | ||
| catch (TopologyException e) { | ||
| throw new PrestoException(INVALID_FUNCTION_ARGUMENT, e.getMessage(), e); |
Contributor
There was a problem hiding this comment.
Is it possible to add a test that triggers this exception and confirm that try allows to suppress it?
3 tasks
martint
pushed a commit
to art4ul/trino
that referenced
this pull request
Jun 28, 2021
Extracted-From: prestodb/presto#14923
martint
pushed a commit
to trinodb/trino
that referenced
this pull request
Jun 28, 2021
Extracted-From: prestodb/presto#14923
OLMS99
pushed a commit
to OLMS99/trino
that referenced
this pull request
Jul 9, 2021
Extracted-From: prestodb/presto#14923
sumannewton
pushed a commit
to sumannewton/trino
that referenced
this pull request
Jan 17, 2022
Extracted-From: prestodb/presto#14923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is similar to PostGIS ST_ClosestPoints. Given two
geometries, find a pair of points on them that have the minimum
distance. If either geometry is empty, return null.
Fixes #14887
Test plan - Unit tests in TestGeoFunctions