Add bing_tile_children and bing_tile_parent functions#14896
Merged
arhimondr merged 1 commit intoprestodb:masterfrom Jul 30, 2020
Merged
Add bing_tile_children and bing_tile_parent functions#14896arhimondr merged 1 commit intoprestodb:masterfrom
arhimondr merged 1 commit intoprestodb:masterfrom
Conversation
arhimondr
approved these changes
Jul 28, 2020
Member
There was a problem hiding this comment.
please add a message in case it ever fails, e.g.: checkArgument(newZoom <= MAX_ZOOM_LEVEL, "newZoom must be less than or equal to %s: %s", MAX_ZOOM_LEVEL, newZoom), same for other checks
Member
There was a problem hiding this comment.
Add the original exception as a cause. Propagate original message. Same for other methods
Member
There was a problem hiding this comment.
assertThatThrownBy(() -> { ... }).hasMessage(...);
Same for other exception checks.
You can also check the exception type and exception fields. Generally the assertThatThrownBy construct is very powerful
Member
There was a problem hiding this comment.
nit: maybe wrap, e.g.:
tiles.stream()
.map(BingTile::toQuadKey)
.sorted()
.collect(Collectors.toList())
Also toImmutableList (statically imported)
Small helper functions to find the children and parent of a BingTile.
arhimondr
approved these changes
Jul 29, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small helper functions to find the children and parent of a BingTile.