Add support for limit pushdown through union#14895
Merged
rongrong merged 1 commit intoprestodb:masterfrom Aug 5, 2020
Merged
Conversation
Contributor
|
Will be nice if this applies to ORDER BY LIMIT as well. LGTM |
rongrong
reviewed
Jul 27, 2020
Contributor
There was a problem hiding this comment.
So, theoretically, this won't fire if the limit here is > 1 either right? Maybe also test that?
Member
Author
There was a problem hiding this comment.
sure I add another test to cover limit2 case
Contributor
There was a problem hiding this comment.
I prefer a separate check before building the list. Something like
if (unionNode.getSources().stream().allMatch(source -> isAtMost(source, context.getLookup(), parent.getCount()))) {
return Result.empty();
}
// build new plan node
It's slightly more efficient when the rule should not fire, which should happen more often.
Member
Author
There was a problem hiding this comment.
yes this check makes sense, will incorporate it.
Contributor
There was a problem hiding this comment.
You don't need to check shouldApply anymore after the check. It should always apply if the code gets here.
fbaf69c to
fa40064
Compare
Cherry-pick of trinodb/trino@f244457 Co-authored-by: praveenkrishna <praveenkrishna@tutanota.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #14894