Skip to content

Upgrade presto-hadoop-apache2 for GCS token refreshing#14890

Merged
zhenxiao merged 1 commit intoprestodb:masterfrom
beinan:beinan/refresh_gcs_token
Jul 29, 2020
Merged

Upgrade presto-hadoop-apache2 for GCS token refreshing#14890
zhenxiao merged 1 commit intoprestodb:masterfrom
beinan:beinan/refresh_gcs_token

Conversation

@beinan
Copy link
Member

@beinan beinan commented Jul 25, 2020

Fix #14832
Upgrade presto-hadoop-apache2 to pick up the commit prestodb/presto-hadoop-apache#43 , which will fix the GCS token not refreshing issue.

Copy link
Collaborator

@zhenxiao zhenxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beinan
Copy link
Member Author

beinan commented Jul 27, 2020

Thank you for the review! @zhenxiao The ci failure looks not relevant, let me rebase and trigger the CI again.

@beinan beinan force-pushed the beinan/refresh_gcs_token branch 3 times, most recently from df1f714 to 4b84d0a Compare July 29, 2020 01:50
@beinan beinan force-pushed the beinan/refresh_gcs_token branch from 4b84d0a to 9e036af Compare July 29, 2020 04:04
@beinan
Copy link
Member Author

beinan commented Jul 29, 2020

All checks passed after 4~5 times of force push. Can I get this one merged? @zhenxiao

@zhenxiao zhenxiao merged commit 0438c0e into prestodb:master Jul 29, 2020
@caithagoras caithagoras mentioned this pull request Aug 14, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Presto 0.234.1 is not accepting dynamically refreshing Access Tokens for accessing GCS

2 participants