Unify grouped execution properties#14886
Merged
rschlussel merged 3 commits intoprestodb:masterfrom Jul 27, 2020
Merged
Conversation
rschlussel
changed the title
viczhang861
approved these changes
Jul 24, 2020
Contributor
viczhang861
left a comment
viczhang861
left a comment
There was a problem hiding this comment.
There is extra space for release note.
rschlussel
force-pushed
the
unify-grouped-execution
branch
from
33edfb7 to
7d3eaa5
Compare
arhimondr
approved these changes
Jul 27, 2020
Member
There was a problem hiding this comment.
Personally I would prefer to disable the grouped execution for local query runner explicitly (or at least explicitly check for the forceSinceNode flag).
Contributor
Author
There was a problem hiding this comment.
updated to check the forceSingleNode flag
Grouped execution is not supported for SystemPartitioningHandles, and will fail gettting the bucket node map. forceSingleNode uses SystemPartitioningHandle.SINGLE_DISTRIBUTION as the partitioning.
Add grouped-execution-enabled property to replace grouped-execution-for-aggregation-enabled, grouped-execution-for-join-enabled, grouped-execution-for-eligible-tablescans-enabled. These other properties will be removed in a future release.
rschlussel
force-pushed
the
unify-grouped-execution
branch
from
7d3eaa5 to
9ff7709
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn grouped execution on by default and introduce a new property grouped_execution to eventually replace all other grouped execution properties
#14885