Skip to content

Fix infinite loop in non-legacy SqlQueryScheduler #14879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschlussel merged 2 commits into from
Jul 27, 2020
Merged

Fix infinite loop in non-legacy SqlQueryScheduler #14879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae1052
Remove extra new line
rschlussel Jul 23, 2020
2004eda
Fix infinite loop in scheduler for finished query
rschlussel Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presto-main/src/main/java/com/facebook/presto/execution/scheduler/SqlQueryScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ private void initialize()
}

@Override

public void start()
{
if (started.compareAndSet(false, true)) {
Expand Down Expand Up @@ -284,6 +283,7 @@ private void schedule()
.collect(toImmutableList()));
if (queryStateMachine.isDone()) {
sectionExecutions.forEach(SectionExecution::abort);
break;
Copy link
Copy Markdown
Contributor

@wenleix wenleix Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume if we clean up executionSchedules list here, we should also be able to break the loop via the condition form 276-278? :)

Copy link
Copy Markdown
Contributor Author

@rschlussel rschlussel Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no the problem is that next time through the loop we'll consider this section "ready for execution" again because the most recent attempt is in a failed state and this might be a retry.

Copy link
Copy Markdown
Contributor

@wenleix wenleix Jul 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

}

sectionExecutions.forEach(sectionExecution -> scheduledStageExecutions.addAll(sectionExecution.getSectionStages()));
Expand Down