Skip to content

Upgrade airlift to 0.193 and discovery-server to 1.32#14869

Merged
arhimondr merged 1 commit intoprestodb:masterfrom
zacw7:update-airlift
Jul 22, 2020
Merged

Upgrade airlift to 0.193 and discovery-server to 1.32#14869
arhimondr merged 1 commit intoprestodb:masterfrom
zacw7:update-airlift

Conversation

@zacw7
Copy link
Member

@zacw7 zacw7 commented Jul 21, 2020

No description provided.

@zacw7 zacw7 requested a review from arhimondr July 21, 2020 21:12
@mayankgarg1990
Copy link

Don't we need to have the refactor as a part of this PR so that we don't have duplicate classes and also so that the authentication framework plugs in properly?

@arhimondr
Copy link
Member

@mayankgarg1990 We need to update the Airlift version to unblock @sujay-jain . But it feels like the #14851 is ready to get merged. So It might make sense to simply update the airlift version in there and get it merged. @zeoh what do you think?

@mayankgarg1990
Copy link

@arhimondr - I don't think just updating the version is a good idea given the changes that should be brought in. In addition to that given that the next release cut is slated for next week, any specific reason for rushing this ? Also, as you said, @zeoh 's PR to take care of the changes in the authenticator is already there - so lets get that merged by tomorrow morning at the latest (I want to ensure a clean build and hence tomorrow morning)

@zacw7
Copy link
Member Author

zacw7 commented Jul 21, 2020

It would be great if I can fully test the new version airlift with presto before merge this PR.

@zacw7 zacw7 changed the title Upgrade airlift to 0.192 Upgrade airlift to 0.192 and discovery-server to 1.32 Jul 22, 2020
@zacw7 zacw7 changed the title Upgrade airlift to 0.192 and discovery-server to 1.32 Upgrade airlift to 0.193 and discovery-server to 1.32 Jul 22, 2020
@arhimondr arhimondr merged commit 4f1b626 into prestodb:master Jul 22, 2020
@zacw7 zacw7 deleted the update-airlift branch July 22, 2020 19:49
@caithagoras caithagoras mentioned this pull request Jul 28, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants