Honor ignore_stats_calculator_failures in getTableStatistics#14849
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Jul 17, 2020
Merged
Honor ignore_stats_calculator_failures in getTableStatistics#14849rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
mbasmanova
approved these changes
Jul 16, 2020
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Looks good to me. Would it be possible to add a test?
rschlussel
force-pushed
the
fix-ignore-stats
branch
2 times, most recently
from
18cbb51 to
14b3683
Compare
Contributor
Author
|
Thanks @mbasmanova. test added |
mbasmanova
approved these changes
Jul 16, 2020
Contributor
There was a problem hiding this comment.
perhaps, use com.facebook.presto.SystemSessionProperties#IGNORE_STATS_CALCULATOR_FAILURES constant
ignore_stats_calculator_failures was getting enforced in cachingStatsProvider and cachingCostProvider. However, InputExtractor was calling getTableStatistics directly, so queries could still fail due to errors computing stats. This was particularly a problem when filters were pushed down to the table scan, because we compute filter stats as part of getTableStatistics().
rschlussel
force-pushed
the
fix-ignore-stats
branch
from
14b3683 to
569bd0f
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore_stats_calculator_failures was getting enforced in
cachingStatsProvider and cachingCostProvider. However, InputExtractor
was calling getTableStatistics directly, so queries could still fail due
to errors computing stats. This was particularly a problem when filters
were pushed down to the table scan, because we compute filter stats as
part of getTableStatistics().