Support return type coercion in CREATE FUNCTION#14822
Merged
caithagoras merged 1 commit intoprestodb:masterfrom Jul 15, 2020
gorthitk:master
Merged
Support return type coercion in CREATE FUNCTION#14822caithagoras merged 1 commit intoprestodb:masterfrom gorthitk:master
caithagoras merged 1 commit intoprestodb:masterfrom
gorthitk:master
Conversation
|
caithagoras
reviewed
Jul 10, 2020
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
caithagoras
reviewed
Jul 14, 2020
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
caithagoras
reviewed
Jul 14, 2020
presto-tests/src/test/java/com/facebook/presto/tests/TestSqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
Contributor
|
Please squash the 3 commits into 1. You can use interactive rebase to achieve that. Presto Review and Commit Guidelines explains this
|
Contributor
|
Please update the release notes section: Please also update the PR description to remove the things about block build. |
caithagoras
approved these changes
Jul 14, 2020
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks for contributing! I'm merge once Travis test is passing. |
caithagoras
reviewed
Jul 14, 2020
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, within CREATE FUNCTION syntax, we currently restrict that the return type declared by the RETURNS clause must exactly match the expression type in the body. The change here will be relaxing that restrictions.