fix inconsistent session value at server and client side#14817
fix inconsistent session value at server and client side#14817mbasmanova merged 1 commit intoprestodb:masterfrom weidongduan37:master
Conversation
|
|
|
@weidongduan37 Thanks for the contribution. Would you squash the commits and see if you can update the commit message to follow these guidelines: https://chris.beams.io/posts/git-commit/? |
tdcmeehan
left a comment
tdcmeehan
left a comment
There was a problem hiding this comment.
@weidongduan37 this fix looks good, but I'm concerned there's no tests for it.
As you mentioned earlier, there doesn't seem to be a current system property that would ever be URL encoded. Perhaps we can enhance the tests in TestPrestoDriver to add a dummy catalog to the TestingPrestoServer that has a generic session property, we could set this property then run SHOW SESSION to verify the property is correctly encoded and decoded. There's an example of something similar DistributedQueryRunner.
Previously, server only encode session value as http header content in response, but do not finish decoding and encoding at client, and decoding at server when receive request. Complete corresponding decoding and encoding from both server and client side.
|
hi @tdcmeehan , I try to add test case as you suggest, but the ci pipeline failed. I check the log, and it seems not related to my changes(presto-cache related). Could you help me to check anything I missed, or what else I can do? Or How can I re-trigger CI pipeline to have a retry without extra commits? thanks. |
3 participants
Fixes #14807