Elasticsearch connector improvements#14811
Merged
zhenxiao merged 8 commits intoprestodb:masterfrom Jul 10, 2020
Merged
Conversation
Collaborator
zhenxiao
commented
Jul 8, 2020
zhenxiao
commented
Cherry-pick of trinodb/trino@101d554 Co-authored-by: Chun Han Hsiao <chhsiao90@gmail.com>
Starting with version 7.x, the publish_address field can contain
addresses of the following form:
cname/ip:port
ip:port
If the CNAME is present, the connector will now use the CNAME and port.
Otherwise, it will use the IP and port.
This change also validates that the address matches one of the above formats.
Cherry-pick of trinodb/trino@68c9392
Co-authored-by: Martin Traverso <mtraverso@gmail.com>
In that case, the connector only needs to produce pages with a row count. We leverage Elasticsearch's count API. Cherry-pick of trinodb/trino@176d229 Co-authored-by: Martin Traverso <mtraverso@gmail.com>
Elastic Search connector exploited column properties map in ColumnMetadata to store extra information needed for execution. Namely: - original colum name (not lower cased) - if column can be used for pushdown Those were not registered in ColumnPropertyManager. That resulted in failures when SHOW CREATE TABLE was executed for Elastic Search table. We fix the issue by not storing extra properties in ColumnMetadata at all. Instead we build Elatics Search ColumnHandle directly from Index Metadata. Cherry-pick of trinodb/trino@d5982fa Co-authored-by: Łukasz Osipiuk <lukasz@osipiuk.net>
Cherry-pick of trinodb/trino@69804f4 Co-authored-by: Łukasz Osipiuk <lukasz@osipiuk.net>
Cherry-pick of trinodb/trino@d312077 Co-authored-by: Alex Albu <alex.albu@starburstdata.com>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.