Skip to content

Fix thread snapshot UI due to variable initialization#14775

Merged
caithagoras merged 2 commits intoprestodb:masterfrom
kvbp2kfb:ui-fix
Jul 7, 2020
Merged

Fix thread snapshot UI due to variable initialization#14775
caithagoras merged 2 commits intoprestodb:masterfrom
kvbp2kfb:ui-fix

Conversation

@kvbp2kfb
Copy link
Contributor

@kvbp2kfb kvbp2kfb commented Jul 2, 2020

== RELEASE NOTES ==

General Changes
* The worker page's thread snapshot UI does not work (no stack trace displayed on click) when there is active query load (tested under Chrome). This patch fixes an uninitialized variable in client JS that was causing this UI behavior.

@kvbp2kfb kvbp2kfb requested a review from swapsmagic July 2, 2020 19:28
@swapsmagic
Copy link
Contributor

Seems like some ui tests failing, let's fix them before we can merge it.

@caithagoras
Copy link
Contributor

@kvbp2kfb The entire release notes section should be enclosed with a pair of triple quotes, not just the single line. I have fixed that for you. You can click on "... -> edit" to see what proper format so that you would know for the next time. Thanks!

@caithagoras
Copy link
Contributor

caithagoras commented Jul 6, 2020

Release notes should be user-facing. What does user see before this fix? Was the page failing to load or something?

@caithagoras caithagoras merged commit 2f5d368 into prestodb:master Jul 7, 2020
@caithagoras caithagoras mentioned this pull request Jul 28, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants