Fix thread snapshot UI due to variable initialization#14775
Merged
caithagoras merged 2 commits intoprestodb:masterfrom Jul 7, 2020
Merged
Fix thread snapshot UI due to variable initialization#14775caithagoras merged 2 commits intoprestodb:masterfrom
caithagoras merged 2 commits intoprestodb:masterfrom
Conversation
swapsmagic
approved these changes
Jul 6, 2020
Contributor
|
Seems like some ui tests failing, let's fix them before we can merge it. |
Contributor
|
@kvbp2kfb The entire release notes section should be enclosed with a pair of triple quotes, not just the single line. I have fixed that for you. You can click on "... -> edit" to see what proper format so that you would know for the next time. Thanks! |
Contributor
|
Release notes should be user-facing. What does user see before this fix? Was the page failing to load or something? |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.