Skip to content

Support common sub-expression optimization in CursorProcessorCompiler #14696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rongrong merged 1 commit into from
Jun 30, 2020
Merged

Support common sub-expression optimization in CursorProcessorCompiler #14696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions presto-main/src/main/java/com/facebook/presto/sql/gen/CommonSubExpressionRewriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
*/
package com.facebook.presto.sql.gen;

import com.facebook.presto.bytecode.BytecodeBlock;
import com.facebook.presto.bytecode.ClassDefinition;
import com.facebook.presto.bytecode.FieldDefinition;
import com.facebook.presto.bytecode.Variable;
import com.facebook.presto.spi.relation.CallExpression;
import com.facebook.presto.spi.relation.ConstantExpression;
import com.facebook.presto.spi.relation.InputReferenceExpression;
Expand All @@ -25,6 +29,7 @@
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Sets;
import com.google.common.primitives.Primitives;

import java.util.ArrayList;
import java.util.Collection;
Expand All @@ -35,6 +40,10 @@
import java.util.Set;
import java.util.stream.Collectors;

import static com.facebook.presto.bytecode.Access.PRIVATE;
import static com.facebook.presto.bytecode.Access.a;
import static com.facebook.presto.bytecode.expression.BytecodeExpressions.constantBoolean;
import static com.facebook.presto.bytecode.expression.BytecodeExpressions.constantNull;
import static com.facebook.presto.spi.relation.SpecialFormExpression.Form.BIND;
import static com.facebook.presto.spi.relation.SpecialFormExpression.Form.WHEN;
import static com.facebook.presto.sql.relational.Expressions.subExpressions;
Expand Down Expand Up @@ -392,4 +401,62 @@ public Integer visitSpecialForm(SpecialFormExpression specialForm, Void collect)
return level;
}
}

static class CommonSubExpressionFields
{
private final FieldDefinition evaluatedField;
private final FieldDefinition resultField;
private final Class<?> resultType;
private final String methodName;

public CommonSubExpressionFields(FieldDefinition evaluatedField, FieldDefinition resultField, Class<?> resultType, String methodName)
{
this.evaluatedField = evaluatedField;
this.resultField = resultField;
this.resultType = resultType;
this.methodName = methodName;
}

public FieldDefinition getEvaluatedField()
{
return evaluatedField;
}

public FieldDefinition getResultField()
{
return resultField;
}

public String getMethodName()
{
return methodName;
}

public Class<?> getResultType()
{
return resultType;
}

public static Map<VariableReferenceExpression, CommonSubExpressionFields> declareCommonSubExpressionFields(ClassDefinition classDefinition, Map<Integer, Map<RowExpression, VariableReferenceExpression>> commonSubExpressionsByLevel)
{
ImmutableMap.Builder<VariableReferenceExpression, CommonSubExpressionFields> fields = ImmutableMap.builder();
commonSubExpressionsByLevel.values().stream().map(Map::values).flatMap(Collection::stream).forEach(variable -> {
Class<?> type = Primitives.wrap(variable.getType().getJavaType());
fields.put(variable, new CommonSubExpressionFields(
classDefinition.declareField(a(PRIVATE), variable.getName() + "Evaluated", boolean.class),
classDefinition.declareField(a(PRIVATE), variable.getName() + "Result", type),
type,
"get" + variable.getName()));
});
return fields.build();
}

public static void initializeCommonSubExpressionFields(Collection<CommonSubExpressionFields> cseFields, Variable thisVariable, BytecodeBlock body)
{
cseFields.forEach(fields -> {
body.append(thisVariable.setField(fields.getEvaluatedField(), constantBoolean(false)));
body.append(thisVariable.setField(fields.getResultField(), constantNull(fields.getResultType())));
});
}
}
}
Loading