Merged
Conversation
highker
reviewed
Jun 7, 2020
...to-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/FileColumnStatistics.java
Outdated
Show resolved
Hide resolved
...to-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/FileColumnStatistics.java
Outdated
Show resolved
Hide resolved
...to-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/FileColumnStatistics.java
Outdated
Show resolved
Hide resolved
presto-hive-metastore/src/main/java/com/facebook/presto/hive/metastore/FileStatistics.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The return format should be a page (or maybe a list of pages). Or if you wanna wrap it, it is also ok. But Page is the essential part for it. That allows the coordinator to write pages into manifests in ORC format.
Here is an example:
| file_prefix | file_name | file_suffix | rows | bytes | col1_min | col1_max | col1_non_null_rows | col2_min | col2_max | col2_non_null_rows |
|---|---|---|---|---|---|---|---|---|---|---|
| ws://ws.atn5/abc/ | 1 | .orc | 1000 | 100030 | ab | zzzd | 900 | 0 | 15 | 1000 |
| ws://ws.atn5/abc/ | 2 | .orc | 1200 | 110040 | ac | zzf | 1100 | 5 | 22 | 1200 |
| ws://ws.atn5/abc/ | 3 | .orc | 1100 | 120050 | bf | xwf | 1000 | 19 | 42 | 1100 |
Each column types should be known beforehand. Or if not, types are serializable anyway, so they can be saved as List<TypeSignature>. For example, the above stats should come with column types: {varchar, varchar, varchar, bigint, bigint, varchar, varchar, bigint, bigint, integer, integer}.
Types and Blocks are the core data structure for Presto. So let's try to reuse them as much as possible.
2ef45cb to
c0f1d21
Compare
highker
reviewed
Jul 10, 2020
presto-hive/src/main/java/com/facebook/presto/hive/OrcFileWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/OrcFileWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveWriter.java
Outdated
Show resolved
Hide resolved
baa383b to
3a5a6f8
Compare
highker
reviewed
Jul 18, 2020
presto-hive/src/main/java/com/facebook/presto/hive/HiveClientModule.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/OrcFileWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/OrcFileWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/OrcFileWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/OrcFileWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
7807e50 to
69feafd
Compare
highker
reviewed
Jul 22, 2020
presto-hive/src/main/java/com/facebook/presto/hive/HiveInvalidFileStatisticsException.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveManifestUtils.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveManifestUtils.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveWriter.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveFileFormats.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/TestHiveManifestUtils.java
Outdated
Show resolved
Hide resolved
9622bb9 to
05df5ce
Compare
highker
approved these changes
Jul 24, 2020
presto-hive-common/src/main/java/com/facebook/presto/hive/HiveErrorCode.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveManifestUtils.java
Outdated
Show resolved
Hide resolved
presto-hive/src/main/java/com/facebook/presto/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
presto-hive/src/test/java/com/facebook/presto/hive/AbstractTestHiveFileFormats.java
Outdated
Show resolved
Hide resolved
05df5ce to
d822111
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect the Partition - file stats (file name, size) from the HiveWriter to be stored in a TBD location and then later use it during scheduling to avoid the directory Listing call.
In this PR we are collecting the stats, tracking the blob size and then throwing it away.
depended by https://github.com/facebookexternal/presto-facebook/pull/1084