Handle coalesce partition handle when bucket count does not match but compatible#14267
Handle coalesce partition handle when bucket count does not match but compatible#14267rongrong merged 2 commits intoprestodb:masterfrom
Conversation
|
cc @caithagoras |
There was a problem hiding this comment.
Should we also update the error message?
|
Consider squashing the commits into one: You can add descriptions about default value changes into the commit message of the 3rd commit. |
|
We should have release notes for the fix. Something like |
|
Thanks for the fix! lgtm, will let @wenleix take a look. |
There was a problem hiding this comment.
what about:
this.handle.equals(other.handle) || metadata.isRefinedPartitioningOver(session, this, other) || metadata.isRefinedPartitioningOver(session, other, this)
There was a problem hiding this comment.
what about
&& metadata.isRefinedPartitioningOver(session, probeProperties.getNodePartitioning().get().getHandle(), buildProperties.getNodePartitioning().get().getHandle()).isPresent()) || metadata.isRefinedPartitioningOver()...
You might want to save probeProperties.getNodePartitioning().get().getHandle() and buildProperties.getNodePartitioning().get().getHandle()).isPresent() as local variable.
|
Now it will be executed as if there are 128 buckets, and cause increase in local memory usage. This is the motivation to deprecate |
Should we have release note for this? It's technically a fix. Also do we have release note for default session value changes?