Add @JsonProperty tag to ignoreNulls flag so it works in distributed …#14221
Add @JsonProperty tag to ignoreNulls flag so it works in distributed …#14221rongrong merged 1 commit intoprestodb:masterfrom
Conversation
There was a problem hiding this comment.
This is probably not needed?
There was a problem hiding this comment.
You can probably write it similar as other tests using assertQueryOrdered and provide expected results, rather than just checking for null (look at testValueWindowFunctions).
There was a problem hiding this comment.
We should not need ordered. So testing for unordered
|
There probably should be a release note since this is a fix. |
kaikalur
force-pushed
the
fix_ignore_nulls
branch
2 times, most recently
from
7471800 to
6320e0c
Compare
Done. |
kaikalur
force-pushed
the
fix_ignore_nulls
branch
from
6320e0c to
3f7277a
Compare
There was a problem hiding this comment.
Nits: separate line for new argument. And empty space between values.
"FROM T",
"Values 1, 2, 2");
There was a problem hiding this comment.
Nits: new line for argument.
assertQuery(
"WITH T ...
There was a problem hiding this comment.
Done. Don't know why 'Reformat Code' doesn't do it automatically though
There was a problem hiding this comment.
I don't think our intelij style setup really conforms with the actual style we are following :(
kaikalur
force-pushed
the
fix_ignore_nulls
branch
2 times, most recently
from
7ce1e15 to
ab76ffa
Compare
…execution as well. Simplified the test. Formatting.
kaikalur
force-pushed
the
fix_ignore_nulls
branch
from
ab76ffa to
bac00b3
Compare
2 participants
Add jsonproperty tag to ignoreNulls so it works in distributed execution as well.
== RELEASE NOTES ==
Fixes a bug in window functions with IGNORE NULLS not working properly in a distributed environment as the flag is not serialized propery.