Skip to content

Limit pushdown for Druid connector#14200

Merged
zhenxiao merged 1 commit intoprestodb:masterfrom
zhenxiao:druid-limit
Mar 4, 2020
Merged

Limit pushdown for Druid connector#14200
zhenxiao merged 1 commit intoprestodb:masterfrom
zhenxiao:druid-limit

Conversation

@zhenxiao
Copy link
Collaborator

@zhenxiao zhenxiao commented Mar 4, 2020 •
edited
Loading 

== RELEASE NOTES ==

Druid Changes
* Add LIMIT evaluation pushdown to Druid connector

@zhenxiao zhenxiao requested a review from highker March 4, 2020 00:55
highker
highker approved these changes Mar 4, 2020
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; could you adjust the release not to be "Add LIMIT evaluation pushdown into connector"?

presto-druid/src/main/java/com/facebook/presto/druid/DruidQueryGeneratorContext.java Outdated
Copy link

@highker highker Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkState

@zhenxiao zhenxiao merged commit f8ee9fd into prestodb:master Mar 4, 2020
@zhenxiao zhenxiao deleted the druid-limit branch March 5, 2020 01:31
@caithagoras caithagoras mentioned this pull request Mar 29, 2020
Merged
9 tasks
@caithagoras caithagoras mentioned this pull request May 4, 2020
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@highker highker highker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhenxiao @highker