Improve correctness check for RowType columns#14036
Improve correctness check for RowType columns#14036mbasmanova merged 1 commit intoprestodb:masterfrom kvaturka:master
Conversation
|
Please take a closer look on validation output format. |
|
@kvaturka Would you squash commits? |
|
Apologize for the delay. I'll get it reviewed by tomorrow morning. |
...o-verifier/src/test/java/com/facebook/presto/verifier/framework/TestVerificationManager.java
Outdated
Show resolved
Hide resolved
...o-verifier/src/test/java/com/facebook/presto/verifier/framework/TestVerificationManager.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/test/java/com/facebook/presto/verifier/checksum/TestChecksumValidator.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/test/java/com/facebook/presto/verifier/checksum/TestChecksumValidator.java
Outdated
Show resolved
Hide resolved
|
This is how our error message looks like in a column mismatch case. The mismatched column section has one column at a time. In a row column case, can we do the same in terms of 1 field per line? That would be more readable. To achieve that, you may want to change |
presto-verifier/src/test/java/com/facebook/presto/verifier/checksum/TestChecksumValidator.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/checksum/RowColumnValidator.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/checksum/RowColumnValidator.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/checksum/RowColumnValidator.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/Column.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/main/java/com/facebook/presto/verifier/framework/Column.java
Outdated
Show resolved
Hide resolved
|
Commit title is too long and thus is cut off. (max 72 characters). |
|
I have changed mismatch output for RowType. |
presto-verifier/src/test/java/com/facebook/presto/verifier/checksum/TestChecksumValidator.java
Outdated
Show resolved
Hide resolved
presto-verifier/src/test/java/com/facebook/presto/verifier/checksum/TestChecksumValidator.java
Outdated
Show resolved
Hide resolved
|
lgtm % nit |
|
Thank you for contributing! |
|
@kvaturka Thank you for the contribution. |
Improve correctness check of row types by applying specific validation to individual fields
Part of #13809