Skip to content

Add statistics handling to the Alluxio metastore support #14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
highker merged 1 commit into from
Feb 2, 2020
Merged

Add statistics handling to the Alluxio metastore support #14018

highker merged 1 commit into from
Feb 2, 2020

Conversation

@haoyuan
Copy link
Contributor

@haoyuan haoyuan commented Jan 27, 2020 •
edited by highker
Loading

Co-authored-by: David Zhu david@alluxio.com

Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines.

Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.

== RELEASE NOTES ==

Hive Changes
*  Add statistics handling to the Alluxio metastore support

@haoyuan haoyuan requested a review from highker January 27, 2020 20:33
highker
highker reviewed Jan 28, 2020
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statisticsObj -> statisticsInfo

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Table table = getTable(databaseName, tableName).orElseThrow(() -> new TableNotFoundException(new SchemaTableName(databaseName, tableName)));

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • spell out colStatsMap
  • null assignment is useless

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one param per line

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break a line

@yuzhu
Copy link
Contributor

yuzhu commented Jan 28, 2020

@highker comments addressed. Thanks!

@haoyuan haoyuan requested a review from highker January 28, 2020 00:58
highker
highker reviewed Jan 28, 2020
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have this. Use makePartName from MetastoreUtil instead of FileUtils.makePartName

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this closer to where it is used.

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break line after this

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

columnStatistics

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basicStatistics

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the formatting is not aligned

            columnStats = client.getPartitionColumnStatistics(
                    table.getDatabaseName(),
                    table.getTableName(),
                    partitionBasicStatistics.keySet().stream().collect(toImmutableList()),
                    dataColumns);

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is alluxio metastore a thrift-based metastore? If not, shall we restructure the util classes so that this class does not depend on ThriftMetastoreUtil? MetastoreUtil might be the right place to host some helpers.

...ve-metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioProtoUtils.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move private functions to the end of a class. Move public ones to the beginning.

...ve-metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioProtoUtils.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant

...e-metastore/src/main/java/com/facebook/presto/hive/metastore/thrift/ThriftMetastoreUtil.java Outdated
Copy link

@highker highker Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to metastoreutil

@haoyuan haoyuan requested a review from rongrong January 28, 2020 18:34
@haoyuan haoyuan requested a review from highker January 31, 2020 00:44
@yuzhu yuzhu force-pushed the stats branch 3 times, most recently from 22684d1 to 819acc4 Compare January 31, 2020 15:56
highker
highker reviewed Feb 1, 2020
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment; otherwise lgtm

...metastore/src/main/java/com/facebook/presto/hive/metastore/alluxio/AlluxioHiveMetastore.java Outdated
Copy link

@highker highker Feb 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, it's better not to depend on thrift utils for non-thrift metastore.

@haoyuan haoyuan requested a review from highker February 1, 2020 19:34
@haoyuan @yuzhu
Add statistics handling to the Alluxio metastore support
80adc5a 
Co-authored-by: David Zhu <david@alluxio.com>
highker
highker approved these changes Feb 2, 2020
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@highker highker merged commit 05310b7 into prestodb:master Feb 2, 2020
@caithagoras caithagoras mentioned this pull request Feb 20, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@highker highker highker approved these changes

@rongrong rongrong Awaiting requested review from rongrong

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haoyuan @yuzhu @highker