Promote Elasticsearch scan performance with index sorting#13987
Merged
zhenxiao merged 2 commits intoprestodb:masterfrom Jan 22, 2020
Merged
Promote Elasticsearch scan performance with index sorting#13987zhenxiao merged 2 commits intoprestodb:masterfrom
zhenxiao merged 2 commits intoprestodb:masterfrom
Conversation
|
|
zhenxiao
reviewed
Jan 22, 2020
Collaborator
zhenxiao
left a comment
zhenxiao
left a comment
There was a problem hiding this comment.
nice work @wuyunfeng
looks good to me, just one style about comments
| .setFetchSource(fields.toArray(new String[0]), null) | ||
| .setQuery(buildSearchQuery()) | ||
| .setPreference("_shards:" + shard) | ||
| // Scroll requests have optimizations that make them faster when the sort order is _doc. |
Collaborator
There was a problem hiding this comment.
how about move the comments above line 106, so that comments not interleave with code?
zhenxiao
reviewed
Jan 22, 2020
...elasticsearch/src/main/java/com/facebook/presto/elasticsearch/ElasticsearchQueryBuilder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@zhenxiao thanks for your review. Can you give me another review? |
Contributor
Author
|
@zhenxiao Thanks for you review |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[https://www.elastic.co/guide/en/elasticsearch/reference/7.5/search-request-body.html#request-body-search-scroll](scroll request)
When Elasticsearch process the scroll request with
_docsort, it will useMinDocQuerycombined with the user's original query , which show as below:https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/search/query/QueryPhase.java#L175-L182
This
scan-scrollrequest we also used onApache - incubator-doris:https://github.com/apache/incubator-doris/blob/master/be/src/exec/es/es_scroll_query.cpp#L118-L120
This PR would promote about 30%+ scan-filter performance for presto-elsticsearch-connector