Enable listing SQL function with session property#13949
Enable listing SQL function with session property#13949rongrong merged 1 commit intoprestodb:masterfrom
Conversation
There was a problem hiding this comment.
Let's call it list_all_functions?
There was a problem hiding this comment.
What about list_sql_functions, list_user_defined_functions, or list_udfs if you think the current name is cumbersome.
For people who don't have context, it's not clear from reading the name what the difference is between "all functions" and "not all functions", and any of those 3 names at least gives some hint.
There was a problem hiding this comment.
But is this only going to list sql functions? it will list all functions right? Unless you are planning to make it an enum and allow only listing certain functions. Another way to configure this is to have it as list_static_functions_only.
There was a problem hiding this comment.
Since we're using "built in function" as the language in our code, I'm updating the PR to use list_built_in_functions_only.
presto-main/src/main/java/com/facebook/presto/metadata/FunctionManager.java
Outdated
Show resolved
Hide resolved
f4c8d53 to
0e1e906
Compare
|
@rongrong Comments addressed. |
04803e5 to
9aa93f3
Compare
ajaygeorge
left a comment
There was a problem hiding this comment.
LGTM.
Try squashing the commits before final merge.
|
Commit squashed. Release notes updated. |
Also, rename configuration property list-non-built-in-functions to list-sql-functions.
|
@rongrong comments addressed |
Resolves #13864