Consuming max buffer size from the session properties #13749
Merged
jainxrohit merged 1 commit intoprestodb:masterfrom Dec 6, 2019
jainxrohit:master
Merged
Consuming max buffer size from the session properties #13749jainxrohit merged 1 commit intoprestodb:masterfrom jainxrohit:master
jainxrohit merged 1 commit intoprestodb:masterfrom
jainxrohit:master
Conversation
|
|
presto-raptor/src/main/java/com/facebook/presto/raptor/RaptorSessionProperties.java
Outdated
Show resolved
Hide resolved
presto-raptor/src/main/java/com/facebook/presto/raptor/RaptorSessionProperties.java
Outdated
Show resolved
Hide resolved
jessesleeping
approved these changes
Nov 26, 2019
Contributor
jessesleeping
left a comment
jessesleeping
left a comment
There was a problem hiding this comment.
Looks good to me. Minor comments:
- Squash the 2 commits into one
- Check if the CI tests are successful
highker
reviewed
Nov 26, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Will leave it to @jessesleeping to review. Could you sign the CLA?
…igs in the Raptor page sink provider. Moving writer max buffer to session configuration, incooprating review comments.
Contributor
Author
@jessesleeping I have squashed both commits in to one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consuming max buffer size from the session properties instead of configs in the Raptor page sink provider.