Skip to content

Enable creating table with table_supports_delta_delete property for raptor#13741

Merged
highker merged 1 commit intoprestodb:masterfrom
kewang1024:Add_delta_delete_support_in_table_property
Nov 26, 2019
Merged

Enable creating table with table_supports_delta_delete property for raptor#13741
highker merged 1 commit intoprestodb:masterfrom
kewang1024:Add_delta_delete_support_in_table_property

Conversation

@kewang1024
Copy link
Collaborator

@kewang1024 kewang1024 commented Nov 23, 2019

== RELEASE NOTES ==

Raptor Changes
* Add table_supports_delta_delete property in Raptor to allow deletion happening in background. DELETE queries in Raptor can now delete data logically but relying on compactors to delete physical data.

@kewang1024 kewang1024 changed the title Enable creating table with table_supports_delta_delete property Enable creating table with table_supports_delta_delete property for raptor Nov 23, 2019
@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch from dab0f07 to 1ea82e7 Compare November 23, 2019 00:28
@kewang1024
Copy link
Collaborator Author

The first PR from #13248

@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch from 1ea82e7 to 312351b Compare November 23, 2019 00:37
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % minor issues

@highker
Copy link

highker commented Nov 24, 2019

The commit message body is not aligned properly. Could you use the following aligned text with punctuation?

Add table_supports_delta_delete in raptor metadata including Metadata
class, table property, and system table. Create index table with
table_supports_delta_delete field. Add table_supports_delta_delete
in 'tables' table.

@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch 2 times, most recently from 0daf642 to 6eb4f45 Compare November 25, 2019 23:44
@kewang1024 kewang1024 requested a review from highker November 25, 2019 23:45
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove storageManagerConfig

@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch from 6eb4f45 to 55a28be Compare November 26, 2019 01:54
@highker highker self-assigned this Nov 26, 2019
@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch from 55a28be to 2fbea3c Compare November 26, 2019 02:02
@kewang1024 kewang1024 requested a review from highker November 26, 2019 03:41
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing. Could you fix that?

@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch from 2fbea3c to b11280c Compare November 26, 2019 06:24
Add table_supports_delta_delete in raptor metadata including Metadata
class, table property and system table. Create index table with
table_supports_delta_delete field. Add table_supports_delta_delete
in 'tables' table.
@kewang1024 kewang1024 force-pushed the Add_delta_delete_support_in_table_property branch from b11280c to 0e8ddd2 Compare November 26, 2019 06:33
@highker highker merged commit 36ec9d2 into prestodb:master Nov 26, 2019
@caithagoras caithagoras mentioned this pull request Dec 18, 2019
14 tasks
@kewang1024 kewang1024 deleted the Add_delta_delete_support_in_table_property branch March 12, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants