Skip to content

Fix IS DISTINCT FROM for decimals with precision > 18 #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbasmanova merged 1 commit into from
Jan 2, 2020
Merged

Fix IS DISTINCT FROM for decimals with precision > 18 #13668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions presto-main/src/main/java/com/facebook/presto/type/DecimalInequalityOperators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ public static boolean distinctBlockPositionLongLong(Block left, int leftPosition

long leftLow = left.getLong(leftPosition, 0);
long leftHigh = left.getLong(leftPosition, SIZE_OF_LONG);
long rightLow = left.getLong(rightPosition, 0);
long rightHigh = left.getLong(rightPosition, SIZE_OF_LONG);
long rightLow = right.getLong(rightPosition, 0);
long rightHigh = right.getLong(rightPosition, SIZE_OF_LONG);
return UnscaledDecimal128Arithmetic.compare(leftLow, leftHigh, rightLow, rightHigh) != 0;
}

Expand Down
13 changes: 13 additions & 0 deletions presto-main/src/test/java/com/facebook/presto/block/TestInt128ArrayBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package com.facebook.presto.block;

import com.facebook.presto.spi.block.Block;
import com.facebook.presto.spi.block.BlockBuilder;
import com.facebook.presto.spi.block.Int128ArrayBlock;
import com.facebook.presto.spi.block.Int128ArrayBlockBuilder;
Expand All @@ -23,7 +24,9 @@
import java.util.Optional;

import static com.facebook.presto.spi.block.Int128ArrayBlock.INT128_BYTES;
import static com.facebook.presto.type.DecimalInequalityOperators.distinctBlockPositionLongLong;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;

public class TestInt128ArrayBlock
Expand Down Expand Up @@ -82,6 +85,16 @@ public void testCompactBlock()
testIncompactBlock(new Int128ArrayBlock(valueIsNull.length - 2, Optional.of(valueIsNull), longArray));
}

@Test
public void testIsDistinctFrom()
{
Block left = new Int128ArrayBlock(1, Optional.empty(), new long[]{112L, 0L});
Block right = new Int128ArrayBlock(1, Optional.empty(), new long[]{185L, 0L});

assertFalse(distinctBlockPositionLongLong(left, 0, left, 0));
assertTrue(distinctBlockPositionLongLong(left, 0, right, 0));
}

private void assertFixedWithValues(Slice[] expectedValues)
{
BlockBuilder blockBuilder = createBlockBuilderWithValues(expectedValues);
Expand Down