Skip to content

Comments

fix organizationDiscoveryIntervalMillis bug#13652

Merged
highker merged 1 commit intoprestodb:masterfrom
kewang1024:fix_organizationDiscoveryIntervalMillis_bug
Nov 6, 2019
Merged

fix organizationDiscoveryIntervalMillis bug#13652
highker merged 1 commit intoprestodb:masterfrom
kewang1024:fix_organizationDiscoveryIntervalMillis_bug

Conversation

@kewang1024
Copy link
Collaborator

@kewang1024 kewang1024 commented Nov 5, 2019 •
edited by highker
Loading 

== RELEASE NOTES ==

Raptor Changes
* Fix organizer not running scheduled job due to misreading `storage.organization-discovery-interval` config.

highker
highker reviewed Nov 5, 2019
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

.../src/main/java/com/facebook/presto/raptor/storage/organization/ShardOrganizationManager.java Outdated
Copy link

@highker highker Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if organizationDiscoveryIntervalMillis is less than 1000? Use MILLISECONDS instead

@kewang1024 kewang1024 force-pushed the fix_organizationDiscoveryIntervalMillis_bug branch from 1f01de7 to d3b4ee5 Compare November 5, 2019 18:38
@kewang1024 kewang1024 force-pushed the fix_organizationDiscoveryIntervalMillis_bug branch from d3b4ee5 to 19cd6cd Compare November 5, 2019 19:30
@kewang1024 kewang1024 requested a review from highker November 6, 2019 00:20
highker
highker approved these changes Nov 6, 2019
View reviewed changes
Copy link

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@highker highker merged commit d9c1e20 into prestodb:master Nov 6, 2019
@leiqingc leiqingc mentioned this pull request Dec 10, 2019
Closed
9 tasks
This was referenced Dec 10, 2019
Closed
Closed
@caithagoras caithagoras mentioned this pull request Dec 18, 2019
Closed
14 tasks
This was referenced Jan 2, 2020
Closed
Merged
@kewang1024 kewang1024 deleted the fix_organizationDiscoveryIntervalMillis_bug branch March 12, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@highker highker highker approved these changes

@jessesleeping jessesleeping Awaiting requested review from jessesleeping

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kewang1024 @highker @facebook-github-bot