Skip to content

Make commitPartition an async operation#13651

Merged
shixuan-fan merged 1 commit intoprestodb:masterfrom
shixuan-fan:async
Nov 20, 2019
Merged

Make commitPartition an async operation#13651
shixuan-fan merged 1 commit intoprestodb:masterfrom
shixuan-fan:async

Conversation

@shixuan-fan
Copy link
Contributor

@shixuan-fan shixuan-fan commented Nov 5, 2019

== RELEASE NOTES ==

SPI Changes
* Change ``ConnectorMetadata#commitPartition`` into async operation, and rename it to ``ConnectorMetadata#commitPartitionAsync``

@shixuan-fan shixuan-fan force-pushed the async branch 2 times, most recently from f8df060 to d65b86d Compare November 5, 2019 06:09
@shixuan-fan shixuan-fan requested a review from wenleix November 5, 2019 20:38
@shixuan-fan shixuan-fan requested a review from arhimondr November 5, 2019 20:38
@shixuan-fan shixuan-fan changed the title [WIP] Make commitPartition an async operation Make commitPartition an async operation Nov 5, 2019
Copy link
Contributor

@wenleix wenleix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Otherwise looks good.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 9, 2019

CLA Check
The committers are authorized under a signed CLA.

  • ✅ Shixuan Fan (9f838feb15b0b495904975b8d0b6a1a46325ae05)

@shixuan-fan shixuan-fan force-pushed the async branch 2 times, most recently from ab9ac78 to 9f838fe Compare November 11, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants