Output verifier events for queries being skipped by pre-filters#13647
Merged
rongrong merged 1 commit intoprestodb:masterfrom Nov 7, 2019
Merged
Output verifier events for queries being skipped by pre-filters#13647rongrong merged 1 commit intoprestodb:masterfrom
rongrong merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
caithagoras
commented
Nov 4, 2019
e25b4d6 to
2173cf0
Compare
Currently, queries pre-filtered are simply discarded with no output events being generated. This changes allows the total output event count to be more predictable. Filters other than blacklist and whitelist will produce a skipped VerifierQueryEvent.
rongrong
approved these changes
Nov 7, 2019
9 tasks
This was referenced Dec 10, 2019
14 tasks
This was referenced Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.