Fix GeometryToBingTiles for certain geometries#13645
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Nov 5, 2019
Merged
Fix GeometryToBingTiles for certain geometries#13645mbasmanova merged 1 commit intoprestodb:masterfrom
mbasmanova merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
cc @mbasmanova |
Geometries that had a max longitude equal to `BingTile.MIN_LONGITUDE` or min latitude equal to `BingTile.MAX_LATITUDE` would originally not get tiled, and with 0.227 would throw an exception. This was due to "trimming" a SE tile to negative tileX or tileY. This change ensures that the SE tile cannot be west or north or the NW tile, preventing those issues.
jagill
force-pushed
the
bing-tile-geometry-fix
branch
from
8599d27 to
de7d875
Compare
mbasmanova
approved these changes
Nov 5, 2019
9 tasks
This was referenced Dec 10, 2019
14 tasks
This was referenced Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geometries that had a max longitude equal to
BingTile.MIN_LONGITUDEor min latitude equal to
BingTile.MAX_LATITUDEwould originallynot get tiled, and with 0.227 would throw an exception. This was due to
"trimming" a SE tile to negative tileX or tileY. This change ensures
that the SE tile cannot be west or north or the NW tile, preventing
those issues.
Fix #13639