Add query integrity check in AccessControlManager#13632
Add query integrity check in AccessControlManager#13632hellium01 wants to merge 1 commit intoprestodb:masterfrom
Conversation
f065d91 to
2c229ab
Compare
presto-spi/src/main/java/com/facebook/presto/spi/security/SystemAccessControl.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/execution/SqlQueryManager.java
Outdated
Show resolved
Hide resolved
5ad1dcd to
afdc6fa
Compare
afdc6fa to
93d35e3
Compare
|
The change overall looks good to me. My only concern is with the naming. Lets get some other opinion on this - @highker , @rschlussel - what are your thoughts on this? |
|
Right, |
93d35e3 to
47a1daf
Compare
47a1daf to
ce459ec
Compare
|
yeah, it's not a perfect fit, but I think it's okay. We are basically saying we won't run your query because you don't have a valid token that we're expecting, so it's a form of an access check. |
|
@highker - can you accept or request changes. I will take over this PR and get it landed |
|
Rebased and opened #13878 so that I can work with the committers to land this |
This PR adds support to validate query integrity before we execute it. Client will provide certain token in
Identity(most likely inextraCredentials).