-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Support CREATE FUNCTION execution #13561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9dcb5e9
Move spi.relation.FullyQualifiedName to spi.QualifiedFunctionName
caithagoras0 25840b5
Require function namespace to be exactly 2 parts
caithagoras0 052b612
Rename SqlInvokedRegularFunction#comment to description
caithagoras0 8688e43
Move classes related to SQL-invoked functions into spi
caithagoras0 6324675
Move SqlInvokedRegularFunctionTestUtils to presto-sql-functions
caithagoras0 5b1a36b
Add ParametersAreNonnullByDefault annotation to cache loading methods
caithagoras0 5638810
Rename FunctionNamespaceManager#rollback to #abort
caithagoras0 077b9aa
Add support for refreshing functions cache in namespace manager
caithagoras0 8defbfe
Support CREATE FUNCTION execution
caithagoras0 cb83587
Fix an issue when fetching function implementation in FunctionManager
caithagoras0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
presto-main/src/main/java/com/facebook/presto/execution/CreateFunctionTask.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.execution; | ||
|
|
||
| import com.facebook.presto.metadata.Metadata; | ||
| import com.facebook.presto.security.AccessControl; | ||
| import com.facebook.presto.spi.PrestoException; | ||
| import com.facebook.presto.spi.function.QualifiedFunctionName; | ||
| import com.facebook.presto.spi.function.RoutineCharacteristics; | ||
| import com.facebook.presto.spi.function.SqlInvokedFunction; | ||
| import com.facebook.presto.spi.function.SqlParameter; | ||
| import com.facebook.presto.spi.type.TypeSignature; | ||
| import com.facebook.presto.sql.analyzer.Analyzer; | ||
| import com.facebook.presto.sql.parser.SqlParser; | ||
| import com.facebook.presto.sql.tree.CreateFunction; | ||
| import com.facebook.presto.sql.tree.Expression; | ||
| import com.facebook.presto.transaction.TransactionManager; | ||
| import com.google.common.util.concurrent.ListenableFuture; | ||
|
|
||
| import javax.inject.Inject; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| import static com.facebook.presto.spi.StandardErrorCode.GENERIC_USER_ERROR; | ||
| import static com.facebook.presto.spi.type.TypeSignature.parseTypeSignature; | ||
| import static com.facebook.presto.sql.SqlFormatter.formatSql; | ||
| import static com.google.common.collect.ImmutableList.toImmutableList; | ||
| import static com.google.common.util.concurrent.Futures.immediateFuture; | ||
| import static java.lang.String.format; | ||
| import static java.util.Locale.ENGLISH; | ||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| public class CreateFunctionTask | ||
| implements DataDefinitionTask<CreateFunction> | ||
| { | ||
| private final SqlParser sqlParser; | ||
|
|
||
| @Inject | ||
| public CreateFunctionTask(SqlParser sqlParser) | ||
| { | ||
| this.sqlParser = requireNonNull(sqlParser, "sqlParser is null"); | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() | ||
| { | ||
| return "CREATE FUNCTION"; | ||
| } | ||
|
|
||
| @Override | ||
| public String explain(CreateFunction statement, List<Expression> parameters) | ||
| { | ||
| return "CREATE FUNCTION " + statement.getFunctionName(); | ||
| } | ||
|
|
||
| @Override | ||
| public ListenableFuture<?> execute(CreateFunction statement, TransactionManager transactionManager, Metadata metadata, AccessControl accessControl, QueryStateMachine stateMachine, List<Expression> parameters) | ||
| { | ||
| Analyzer analyzer = new Analyzer(stateMachine.getSession(), metadata, sqlParser, accessControl, Optional.empty(), parameters, stateMachine.getWarningCollector()); | ||
| analyzer.analyze(statement); | ||
| metadata.getFunctionManager().createFunction(createSqlInvokedFunction(statement), statement.isReplace()); | ||
| return immediateFuture(null); | ||
| } | ||
|
|
||
| private SqlInvokedFunction createSqlInvokedFunction(CreateFunction statement) | ||
| { | ||
| if (statement.getFunctionName().getParts().size() != 3) { | ||
| throw new PrestoException(GENERIC_USER_ERROR, format("Invalid function name: %s, require exactly 3 parts", statement.getFunctionName())); | ||
| } | ||
|
|
||
| QualifiedFunctionName functionName = QualifiedFunctionName.of(statement.getFunctionName().toString()); | ||
| List<SqlParameter> parameters = statement.getParameters().stream() | ||
| .map(parameter -> new SqlParameter(parameter.getName().toString().toLowerCase(ENGLISH), parseTypeSignature(parameter.getType()))) | ||
| .collect(toImmutableList()); | ||
| TypeSignature returnType = parseTypeSignature(statement.getReturnType()); | ||
| String description = statement.getComment().orElse(""); | ||
| RoutineCharacteristics routineCharacteristics = new RoutineCharacteristics( | ||
| RoutineCharacteristics.Language.valueOf(statement.getCharacteristics().getLanguage().name()), | ||
| RoutineCharacteristics.Determinism.valueOf(statement.getCharacteristics().getDeterminism().name()), | ||
| RoutineCharacteristics.NullCallClause.valueOf(statement.getCharacteristics().getNullCallClause().name())); | ||
| String body = formatSql(statement.getBody(), Optional.empty()); | ||
|
|
||
| return new SqlInvokedFunction( | ||
| functionName, | ||
| parameters, | ||
| returnType, | ||
| description, | ||
| routineCharacteristics, | ||
| body, | ||
| Optional.empty()); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.