Move SetOperationNode to SPI#13546
Merged
highker merged 1 commit intoprestodb:masterfrom Oct 22, 2019
Merged
Conversation
highker
commented
Oct 14, 2019
highker
commented
highker
force-pushed
the
set
branch
3 times, most recently
from
874a77d to
be6420e
Compare
hellium01
reviewed
Oct 14, 2019
Contributor
hellium01
left a comment
hellium01
left a comment
There was a problem hiding this comment.
Looks good in general, just a few comments on saving back/forth conversion of ListMultiMap and Map<K,List<V>>.
...-main/src/main/java/com/facebook/presto/sql/planner/optimizations/SetOperationNodeUtils.java
Outdated
Show resolved
Hide resolved
...ain/src/main/java/com/facebook/presto/sql/planner/optimizations/UnaliasSymbolReferences.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/plan/IntersectNode.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/plan/SetOperationNode.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/plan/SetOperationNode.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/cost/UnionStatsRule.java
Outdated
Show resolved
Hide resolved
rongrong
reviewed
Oct 15, 2019
...-main/src/main/java/com/facebook/presto/sql/planner/optimizations/SetOperationNodeUtils.java
Outdated
Show resolved
Hide resolved
rongrong
reviewed
Oct 15, 2019
presto-spi/src/main/java/com/facebook/presto/spi/plan/SetOperationNode.java
Outdated
Show resolved
Hide resolved
arhimondr
reviewed
Oct 18, 2019
Member
arhimondr
left a comment
arhimondr
left a comment
There was a problem hiding this comment.
The code looks good to me. Leaving the right to approve to @hellium01 / @rongrong as they have better overall context
...-main/src/main/java/com/facebook/presto/sql/planner/optimizations/SetOperationNodeUtils.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/plan/SetOperationNode.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/plan/UnionNode.java
Outdated
Show resolved
Hide resolved
Author
|
Comments addressed. Thanks for review. |
highker
force-pushed
the
set
branch
2 times, most recently
from
1f35df2 to
2d4f1da
Compare
hellium01
approved these changes
Oct 22, 2019
Contributor
hellium01
left a comment
hellium01
left a comment
There was a problem hiding this comment.
Looks good for me. Just a nit comment.
Probably @rongrong / @arhimondr can take a final look?
presto-spi/src/main/java/com/facebook/presto/spi/plan/SetOperationNode.java
Outdated
Show resolved
Hide resolved
Allows connectors to create union node
arhimondr
approved these changes
Oct 22, 2019
This was referenced Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.