Passing X_Forwarded_For in header from proxy server#13527
Merged
swapsmagic merged 1 commit intoprestodb:masterfrom Oct 17, 2019
Merged
Passing X_Forwarded_For in header from proxy server#13527swapsmagic merged 1 commit intoprestodb:masterfrom
swapsmagic merged 1 commit intoprestodb:masterfrom
Conversation
swapsmagic
force-pushed
the
log_original_client_ip
branch
2 times, most recently
from
13b9c46 to
4db8cc9
Compare
swapsmagic
requested review from
achao,
shixuan-fan and
varungajjala
and removed request for
achao
swapsmagic
force-pushed
the
log_original_client_ip
branch
3 times, most recently
from
c8d07e9 to
fb5c9b7
Compare
shixuan-fan
approved these changes
Oct 16, 2019
Contributor
shixuan-fan
left a comment
shixuan-fan
left a comment
There was a problem hiding this comment.
LGTM. Make sure Jenkins is green before merging
presto-proxy/src/main/java/com/facebook/presto/proxy/ProxyResource.java
Outdated
Show resolved
Hide resolved
swapsmagic
force-pushed
the
log_original_client_ip
branch
from
fb5c9b7 to
51e5829
Compare
swapsmagic
force-pushed
the
log_original_client_ip
branch
from
51e5829 to
755bab2
Compare
This was referenced Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presto Proxy doesn't pass client address and so presto cluster thinks proxy being the initiating client. As part of this change, proxy will start sending client address in X_Forwarded_For header so it can be used by Presto cluster and log it correctly.