Implement Basic Example For Jdbc Row Expression Translation#13526
Merged
highker merged 1 commit intoprestodb:masterfrom Oct 22, 2019
Merged
Implement Basic Example For Jdbc Row Expression Translation#13526highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
highker
reviewed
Oct 9, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Let's have the other PR cleaned up; then work on this one.
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
2 times, most recently
from
6e2124b to
2c24108
Compare
Contributor
Author
|
Rebased onto #13491. Now figuring out how much more work is remaining for a good example of row expression translation. |
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
from
2c24108 to
87fd199
Compare
sachdevs
changed the title
sachdevs
changed the title
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
from
87fd199 to
6ea192e
Compare
highker
reviewed
Oct 15, 2019
...src/main/java/com/facebook/presto/plugin/jdbc/optimization/function/JdbcTranslationUtil.java
Outdated
Show resolved
Hide resolved
...bc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcPlanOptimizerProvider.java
Outdated
Show resolved
Hide resolved
...bc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcPlanOptimizerProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/facebook/presto/plugin/jdbc/optimization/function/OperatorTranslators.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcSql.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/facebook/presto/plugin/jdbc/optimization/RowExpressionToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/facebook/presto/plugin/jdbc/optimization/RowExpressionToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/facebook/presto/plugin/jdbc/optimization/RowExpressionToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/facebook/presto/plugin/jdbc/optimization/RowExpressionToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...ase-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
3 times, most recently
from
458129d to
878202b
Compare
Contributor
Author
|
There seem to be a few unexpected test failures - unsure why they are happening since this should be a no-op. Debugging now... |
highker
reviewed
Oct 15, 2019
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcSplitManager.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcConnector.java
Outdated
Show resolved
Hide resolved
...ase-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
...bc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...jdbc/src/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
...jdbc/src/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
...jdbc/src/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
...jdbc/src/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcSql.java
Outdated
Show resolved
Hide resolved
hellium01
reviewed
Oct 15, 2019
Contributor
There was a problem hiding this comment.
Let's put Map<VariableReferenceExpression, ColumnHandle> as a member instead of Context
Contributor
Author
There was a problem hiding this comment.
How would we do this? at creation of JdbcFilterToSqlTranslator, we do not know what the assignments map will be.
Contributor
There was a problem hiding this comment.
I remembered the interface was TranslatedExpression<JdbcSql>? I am fine with both though.
Contributor
Author
There was a problem hiding this comment.
It was, it was changed during this PR, see #13526 (comment)
...rc/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcFilterToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcFilterToSqlTranslator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Found the source of failing tests: Need to make JdbcSql Json serializable using Jackson since it is a serializable property on JdbcTableLayoutHandle. |
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
from
878202b to
46e9e71
Compare
Contributor
Author
|
Writing tests currently and resolving leftover comments. Using commit to check travis run to see if any regressions. |
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
3 times, most recently
from
9b18b69 to
612a964
Compare
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
from
612a964 to
4000031
Compare
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
2 times, most recently
from
77dc745 to
9115569
Compare
Contributor
Author
|
One of my concerns with this is that I changed JdbcSplit's additionalPredicate type to JdbcExpression. Nothing seems to have been using it so I felt that it was fair to change. Other than that no functionality was touched. |
highker
reviewed
Oct 19, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Minor comments only. Otherwise all look good to me
...bc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java
Outdated
Show resolved
Hide resolved
...bc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcFilterToSqlTranslator.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcSplitManager.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcTableLayoutHandle.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcTableLayoutHandle.java
Outdated
Show resolved
Hide resolved
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/optimization/JdbcExpression.java
Outdated
Show resolved
Hide resolved
...jdbc/src/test/java/com/facebook/presto/plugin/jdbc/optimization/TestJdbcComputePushdown.java
Outdated
Show resolved
Hide resolved
hellium01
reviewed
Oct 19, 2019
...to-base-jdbc/src/test/java/com/facebook/presto/plugin/jdbc/TestJdbcIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
...to-base-jdbc/src/test/java/com/facebook/presto/plugin/jdbc/TestJdbcIntegrationSmokeTest.java
Outdated
Show resolved
Hide resolved
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
4 times, most recently
from
512b0f3 to
14e85a3
Compare
highker
approved these changes
Oct 21, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
One minor comment; otherwise, looks good to me
presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/JdbcClient.java
Outdated
Show resolved
Hide resolved
sachdevs
force-pushed
the
jdbc-row-expression-translation
branch
from
14e85a3 to
60aa2ee
Compare
Contributor
Author
|
To be merged alongside: https://github.com/facebookexternal/presto-facebook/pull/703 |
Contributor
Author
|
Rerunning timed out test. Seems to be unrelated (hive tests). |
This was referenced Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #13491 for interface that this is built on.