Move RowExpression translation above AddExchange#13521
Merged
highker merged 2 commits intoprestodb:masterfrom Oct 22, 2019
Merged
Move RowExpression translation above AddExchange#13521highker merged 2 commits intoprestodb:masterfrom
highker merged 2 commits intoprestodb:masterfrom
Conversation
highker
force-pushed
the
addEx
branch
6 times, most recently
from
f910d36 to
c68ceac
Compare
highker
force-pushed
the
addEx
branch
4 times, most recently
from
e6dd9ac to
965ab95
Compare
Author
|
Ready for review. @rongrong, @wenleix, @arhimondr, just noticed that it is safe to move connector optimization rule before |
Author
|
NVM, we might still need two. |
highker
force-pushed
the
addEx
branch
2 times, most recently
from
dbccc99 to
4ff3ede
Compare
hellium01
approved these changes
Oct 21, 2019
Contributor
hellium01
left a comment
hellium01
left a comment
There was a problem hiding this comment.
The change looks very clean to me. Just a nit comment.
presto-main/src/main/java/com/facebook/presto/sql/planner/optimizations/AddExchanges.java
Outdated
Show resolved
Hide resolved
wenleix
approved these changes
Oct 22, 2019
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/PickTableLayout.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.