Optimize PlanFragment Serialization#13451
Conversation
ebf06cd to
c19c5e4
Compare
c19c5e4 to
18a592f
Compare
presto-main/src/main/java/com/facebook/presto/sql/planner/PlanFragment.java
Outdated
Show resolved
Hide resolved
|
I did some performance profiling in production workload and it turns out serializing splits is dominating the This PR is still valuable since it reduce the bytes sent to worker from coordinator. Too large update has been demonstrated to cause troubles (see, e.g. #13360) and aligns with the Coordinator reliability efforts such as #13584 . |
18a592f to
d775fb0
Compare
There was a problem hiding this comment.
Remove this comment as well
presto-main/src/main/java/com/facebook/presto/sql/planner/PlanFragment.java
Outdated
Show resolved
Hide resolved
|
For the commit subject, I would say "Optimize PlanFragment serialization". "PlanFragment" is not an action, you cannot optimize "PlanFragment" :) . |
d775fb0 to
a3464d1
Compare
Dont send PlanFragment's jsonRepresentation, statsAndCosts to workers as they do not need it.
a3464d1 to
325c37d
Compare
Do not send PlanFragment's jsonRepresentation, statsAndCosts to workers as they don't need it.
They are only for the coordinator UI purpose.