Skip to content

Add Presto Pinot Connector #13413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haibow wants to merge 2 commits into from
Closed

Add Presto Pinot Connector #13413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25b39bc
Add Pinot connector
haibow Sep 13, 2019
991e636
Address comments first pass
haibow Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,15 @@
<dep.nexus-staging-plugin.version>1.6.8</dep.nexus-staging-plugin.version>
<dep.asm.version>6.2.1</dep.asm.version>
<dep.gcs.version>1.9.17</dep.gcs.version>
<dep.httpcore.version>4.4.6</dep.httpcore.version>
<dep.httpclient.version>4.5.3</dep.httpclient.version>
Copy link

@highker highker Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use airlift library for http clients

<dep.yammer.version>2.2.0</dep.yammer.version>
<dep.fastjson.version>1.1.24</dep.fastjson.version>
Copy link

@highker highker Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use jackson or smile for json parser

<dep.netty.version>3.10.6.Final</dep.netty.version>
Copy link

@highker highker Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many dependencies. @wenleix @hellium01, could you help taking a look if there is anything we could remove? For example, is it possible to use com.facebook.drift.transport.netty lib? We have explicitly excluded netty-all dep in this file.

Copy link
Member

@arhimondr arhimondr Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of trying to force the specific version module / project wise - the pinot client has to be shaded (see https://github.com/prestodb/presto-cassandra-server, https://github.com/prestodb/presto-cassandra-driver)

<dep.netty-all.version>4.1.28.Final</dep.netty-all.version>
<dep.validation-api.version>2.0.1.Final</dep.validation-api.version>
Copy link

@highker highker Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line; validation-api 1.1.0 is already available. Check other connectors.

<dep.jersey-core.version>2.28</dep.jersey-core.version>
<dep.pinot.version>0.1.0</dep.pinot.version>

<!--
America/Bahia_Banderas has:
Expand Down Expand Up @@ -138,6 +147,7 @@
<module>presto-proxy</module>
<module>presto-kudu</module>
<module>presto-elasticsearch</module>
<module>presto-pinot</module>
</modules>

<dependencyManagement>
Expand Down
4 changes: 4 additions & 0 deletions presto-main/etc/catalog/pinot.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
connector.name=pinot
Copy link

@highker highker Sep 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file may not be necessary.

Copy link
Author

@haibow haibow Sep 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it here to help testing locally. Is it ok to keep it here?

zookeeper-uri=localhost:2181
pinot-cluster=PinotCluster
controller-url=localhost:9000
1 change: 1 addition & 0 deletions presto-main/etc/config.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ plugin.bundles=\
../presto-mysql/pom.xml,\
../presto-sqlserver/pom.xml, \
../presto-postgresql/pom.xml, \
../presto-pinot/pom.xml, \
../presto-tpcds/pom.xml

presto.version=testversion
Expand Down
Loading