Improve Presto Query Page UI#13158
Conversation
arhimondr
left a comment
There was a problem hiding this comment.
@nausicaasnow Thanks for working on this!
Generally looks good. Few comments:
-
Could you please tweak the layout a little bit, so the head of the tasks table and the data are aligned

-
Could you please do the rebase
git fetch origin; git rebase -i origin/master;and squash the merge commit? So the change has only a single commit? -
You need to rebuild the UI and commit the generated JS, otherwise the build won't pass.
-
nit and optional: Usually we are trying to minimize the amount of changes needed. The reformatting the table header makes code better but it isn't a part of the solution to the problem, thus i would suggest to put it into a separate commit.
|
Let's give a chance for @ggreg to have a look |
|
Second @arhimondr's comments. Otherwise the change looks good to me. Thanks a lot for working on this! |
Distribute the tasks into every stage and only display when expanding stage summary, which is to avoid tasks flushing, the auto-fresh behaviors of tasks are now consistent with stage's. The 'None' is removed from task filter, the default value now is 'ALL'.
rongrong
left a comment
There was a problem hiding this comment.
Looks good! Since there's a reformatting commit, is this the only reformat needed?
Not sure. I was just trying to preserve the original code =) |
Well my review for the initial code would also be "remove reformatting since it's not related or maybe try to do a better job". But I won't be too picky since it's strictly better than before. |
|
The product test failure is unrelated |

Distribute the tasks into every stage and only display when expanding stage summary, which is to avoid tasks flushing, the auto-fresh behaviors of tasks are now consistent with stage's.
The 'None' is removed from task filter, the default value now is 'ALL'.