Row expression predicate pushdown#13112
Merged
highker merged 2 commits intoprestodb:masterfrom Oct 20, 2019
Merged
Conversation
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
95e74b9 to
9f4bd03
Compare
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
2 times, most recently
from
64e7ac2 to
1d0f2f4
Compare
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
8 times, most recently
from
11fd8a6 to
0f5f54e
Compare
hellium01
changed the title
highker
reviewed
Aug 15, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Let's fix the other PR and then come back to this one.
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
2 times, most recently
from
9b95f73 to
2e3478e
Compare
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
4 times, most recently
from
25bc1db to
96d90cf
Compare
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
4 times, most recently
from
4fe9f50 to
472de3d
Compare
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
472de3d to
dc63362
Compare
Contributor
Author
|
Ran explain verifier with 100K queries and found no change in query plan result. |
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
dc63362 to
2831eb6
Compare
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
6 times, most recently
from
238e73b to
5eceb90
Compare
highker
reviewed
Oct 16, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
"Add RowExpressionPredicateExtractor" LGTM
presto-main/src/main/java/com/facebook/presto/sql/planner/RowExpressionPredicateExtractor.java
Outdated
Show resolved
Hide resolved
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
5eceb90 to
df98eae
Compare
highker
reviewed
Oct 16, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
predicate pushdown; not finished review yet
.../main/java/com/facebook/presto/sql/planner/optimizations/RowExpressionPredicatePushDown.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/optimizations/RowExpressionPredicatePushDown.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/optimizations/RowExpressionPredicatePushDown.java
Outdated
Show resolved
Hide resolved
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
2 times, most recently
from
36254e7 to
1c328d9
Compare
|
@hellium01, could you do a quick rebase? I have merged #13560. I will review the rest two commits today. |
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
1c328d9 to
957e99a
Compare
Contributor
Author
|
Yes, rebased and improved the test coverage a little bit. |
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
957e99a to
de39317
Compare
highker
approved these changes
Oct 17, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Compared line by line; didn't see anything wrong. But still, it would be better to run more explain tests
presto-main/src/test/java/com/facebook/presto/sql/planner/iterative/rule/test/PlanBuilder.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/facebook/presto/sql/planner/optimizations/StatsRecordingPlanOptimizer.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/sql/planner/assertions/RowExpressionVerifier.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/optimizations/RowExpressionPredicatePushDown.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/sql/planner/TestPredicatePushdown.java
Outdated
Show resolved
Hide resolved
hellium01
force-pushed
the
RowExpressionPredicatePushdown
branch
from
de39317 to
8e72b96
Compare
This was referenced Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushdown RowExpression predicates. On top of #13560