Fixup unaddressed comments#12967
Merged
hellium01 merged 4 commits intoprestodb:masterfrom Jun 18, 2019
Merged
Conversation
highker
reviewed
Jun 18, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
"Fixup Allow type coercion in DependencyChecker" -> Add type coercion comments for DependencyChecker
highker
reviewed
Jun 18, 2019
There was a problem hiding this comment.
put this line in the previous one; same for other 3 places.
There was a problem hiding this comment.
add comments: to avoid assert plan failure not printing out plan (for #12885).
highker
approved these changes
Jun 18, 2019
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
Separate "Fixup Replace Expression in Assignments to RowExpression" into
- "Move out isExpression check from SymbolsExtractor": add commit msg body: the caller is responsible for checking if a row expression is an expression to avoid silent failure.
- "Minor PlanFragmenter variable rename"
The caller should check isExpression explicitly so that failure will throw at the violating optimization rule instead of silent failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some comments unaddressed in: #12747