Conversation
shixuan-fan
left a comment
shixuan-fan
left a comment
There was a problem hiding this comment.
Before "Split out queued phase from QueryManager" looks good
raghavsethi
force-pushed
the
dispatcher-final-rebase
branch
from
1d1c344 to
a571ef8
Compare
The normal minimum worker requirement applied to all queries is sufficient to cover this case.
A query will be in the DISPATCHING state during handoff to a query execution coordinator.
resourceGroup is already required in QueryStateMachine
querySubmitter should never throw, but if it does fail the query immediately
Previously, the cache was effectively disabled for the first result, so a retry on first request resulted in a 410 gone.
raghavsethi
force-pushed
the
dispatcher-final-rebase
branch
from
a571ef8 to
b5283fc
Compare
|
Rebased onto master.
|
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
@tooptoop4: Sorry, I no longer work for Facebook. As per my last conversation with @tdcmeehan, he plans to work on this later this year. In the meantime you could try cherry-picking the commits from trinodb/trino#95 if you have an urgent use case. |
|
@tooptoop4 out of curiosity what's your use case for this PR? |
|
This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions! |
|
#14104 adds these changes |
6 participants
Reviewed at trinodb/trino#95
Original issue: #10174
More detail on motivation: trinodb/trino#391