Replace Assignments::Expression with RowExpression#12715
Closed
highker wants to merge 6 commits intoprestodb:masterfrom
Closed
Replace Assignments::Expression with RowExpression#12715highker wants to merge 6 commits intoprestodb:masterfrom
highker wants to merge 6 commits intoprestodb:masterfrom
Conversation
8 tasks
highker
force-pushed
the
proj
branch
2 times, most recently
from
7921b3a to
f912747
Compare
Author
|
Hand over to @hellium01 to finish the patch |
rongrong
reviewed
Apr 30, 2019
|
|
||
| Map<String, ColumnHandle> columns = metadata.getColumnHandles(session, insert.getTarget()); | ||
| Assignments.Builder assignments = Assignments.builder(); | ||
| AssignmentsUtils.Builder assignments = AssignmentsUtils.builder(); |
Contributor
There was a problem hiding this comment.
I'd call this AssignmentBuilder if it's in AssignmentUtils. And you can pretty much static import that.
| List<Symbol> outputSymbols = node.getOutputSymbols(); | ||
|
|
||
| return visitScanFilterAndProject(context, node.getId(), sourceNode, Optional.of(filterExpression), Assignments.identity(outputSymbols), outputSymbols); | ||
| return visitScanFilterAndProject(context, node.getId(), sourceNode, Optional.of(filterExpression), AssignmentsUtils.identity(outputSymbols), outputSymbols); |
Contributor
There was a problem hiding this comment.
why not change to static import
| .build(); | ||
| } | ||
|
|
||
| public static Assignments of() |
Contributor
There was a problem hiding this comment.
These name should be changed if they are no longer in the Assignments class. It's ok to call the static creator of, but that's really strange from another class. I don't know what to call them though.
Author
|
superseded by #12747 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No dependency